Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Modify prebuilt UI designs #844

Merged
merged 26 commits into from
Aug 30, 2024
Merged

feat: Modify prebuilt UI designs #844

merged 26 commits into from
Aug 30, 2024

Conversation

ohansFavour
Copy link
Contributor

@ohansFavour ohansFavour commented Aug 4, 2024

Summary of change

This PR updates the prebuilt UI designs

New designs

Test

Design and functionality

  • tested in Chrome
  • Tested on Safari
  • Tested on Firefox

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If added a new recipe interface, then make sure that the implementation of it uses NON arrow functions only (like someFunc: function () {..}).
  • If I added a new recipe, I also added the recipe entry point into the size-limit section of package.json with the size limit set to the current size rounded up.
  • If I added a new recipe, I also added the recipe entry point into the rollup.config.mjs
  • If I added a new login method, I modified the list in lib/ts/types.ts
  • If I added a factor id, I modified the list in lib/ts/recipe/multifactorauth/types.ts

Remaining TODOs for this PR

  • Item1
  • Item2

@ohansFavour ohansFavour marked this pull request as draft August 4, 2024 13:02
Copy link

github-actions bot commented Aug 4, 2024

size-limit report 📦

Path Size
lib/build/index.js 22.89 KB (+0.92% 🔺)
recipe/session/index.js 23.64 KB (+0.81% 🔺)
recipe/session/prebuiltui.js 28.18 KB (+1.08% 🔺)
recipe/thirdparty/index.js 31.48 KB (+0.46% 🔺)
recipe/emailpassword/index.js 11.07 KB (0%)
recipe/emailverification/index.js 7.84 KB (-0.02% 🔽)
recipe/passwordless/index.js 14.89 KB (0%)
recipe/emailverification/prebuiltui.js 32.93 KB (+1.24% 🔺)
recipe/thirdparty/prebuiltui.js 51.75 KB (+1.21% 🔺)
recipe/emailpassword/prebuiltui.js 38.99 KB (+0.77% 🔺)
recipe/passwordless/prebuiltui.js 126.78 KB (+0.62% 🔺)
recipe/multitenancy/index.js 6.67 KB (-0.02% 🔽)
recipe/multifactorauth/index.js 10.9 KB (0%)
recipe/multifactorauth/prebuiltui.js 31.86 KB (+0.9% 🔺)

@ohansFavour ohansFavour marked this pull request as ready for review August 5, 2024 04:44
@rishabhpoddar
Copy link
Member

Continue with Custom is misaligned compared to other buttons...

@rishabhpoddar
Copy link
Member

Also, missing changes for other pages (like email verification and magic link ones)

@ohansFavour ohansFavour marked this pull request as draft August 21, 2024 13:54
@ohansFavour ohansFavour changed the base branch from master to 0.47 August 27, 2024 08:31
@ohansFavour ohansFavour marked this pull request as ready for review August 27, 2024 08:31
CHANGELOG.md Outdated Show resolved Hide resolved
lib/ts/recipe/passwordless/components/themes/styles.css Outdated Show resolved Hide resolved
lib/ts/styles/styles.css Show resolved Hide resolved
test/server/index.js Outdated Show resolved Hide resolved
@ohansFavour ohansFavour changed the title feat: Modify providerButton styles feat: Modify prebuilt UI designs Aug 28, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@porcellus porcellus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please double check the http://localhost:6006/?path=/story/emailverification--link-clicked-invalid-token screen as well - I think it looks strange.

lib/ts/recipe/emailpassword/components/themes/styles.css Outdated Show resolved Hide resolved
examples/for-tests/src/App.js Outdated Show resolved Hide resolved
@porcellus porcellus merged commit 0485cfb into 0.47 Aug 30, 2024
23 of 29 checks passed
@porcellus porcellus deleted the feat/update-prebuilt-ui branch August 30, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants