Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only show continue with passwordless if email pwless is enabled #859

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

porcellus
Copy link
Collaborator

@porcellus porcellus commented Sep 18, 2024

Summary of change

Fixed an issue where we showed the "continue with passwordless" button during sign-in even if email-based passwordless was disabled by the tenant configuration.

Related issues

Test Plan

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If added a new recipe interface, then make sure that the implementation of it uses NON arrow functions only (like someFunc: function () {..}).
  • If I added a new recipe, I also added the recipe entry point into the size-limit section of package.json with the size limit set to the current size rounded up.
  • If I added a new recipe, I also added the recipe entry point into the rollup.config.mjs
  • If I added a new login method, I modified the list in lib/ts/types.ts
  • If I added a factor id, I modified the list in lib/ts/recipe/multifactorauth/types.ts

Remaining TODOs for this PR

  • Item1
  • Item2

Copy link

size-limit report 📦

Path Size
lib/build/index.js 22.9 KB (0%)
recipe/session/index.js 23.64 KB (0%)
recipe/session/prebuiltui.js 28.19 KB (0%)
recipe/thirdparty/index.js 31.48 KB (0%)
recipe/emailpassword/index.js 11.07 KB (0%)
recipe/emailverification/index.js 7.84 KB (0%)
recipe/passwordless/index.js 14.88 KB (0%)
recipe/emailverification/prebuiltui.js 32.94 KB (0%)
recipe/thirdparty/prebuiltui.js 51.76 KB (0%)
recipe/emailpassword/prebuiltui.js 39.01 KB (0%)
recipe/passwordless/prebuiltui.js 126.82 KB (+0.02% 🔺)
recipe/multitenancy/index.js 6.67 KB (0%)
recipe/multifactorauth/index.js 10.9 KB (0%)
recipe/multifactorauth/prebuiltui.js 31.87 KB (0%)

@porcellus porcellus merged commit 15dac20 into 0.47 Sep 18, 2024
25 of 30 checks passed
@porcellus porcellus deleted the fix/continue_with_passwordless_factorids branch September 18, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant