Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add debug logs #118

Merged
merged 18 commits into from
Jan 3, 2024
Merged

feat: Add debug logs #118

merged 18 commits into from
Jan 3, 2024

Conversation

prateek3255
Copy link
Contributor

@prateek3255 prateek3255 commented Jan 3, 2024

Summary of change

  • Add debug logs to the SDK and update the initializer to allow the user to enable those logs

Related issues

N/A

Test Plan

Tried this version in a demo app with enableDebugLogs set to true and was able to view the logs:
image

Documentation changes

N/A

Checklist for important updates

  • Changelog has been updated
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in lib/ts/version.ts
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.

Remaining TODOs for this PR

N/A

@prateek3255 prateek3255 changed the title Add debug logs feat: Add debug logs Jan 3, 2024
Copy link

github-actions bot commented Jan 3, 2024

size-limit report 📦

Path Size
lib/build/index.js 26.13 KB (+7.18% 🔺)

@prateek3255 prateek3255 changed the base branch from master to 4.1 January 3, 2024 07:23
@prateek3255 prateek3255 marked this pull request as ready for review January 3, 2024 07:34
package-lock.json Show resolved Hide resolved
package.json Show resolved Hide resolved
lib/ts/utils.ts Outdated Show resolved Hide resolved
lib/ts/logger.ts Outdated Show resolved Hide resolved
lib/ts/logger.ts Show resolved Hide resolved
lib/ts/types.ts Show resolved Hide resolved
lib/ts/fetch.ts Outdated Show resolved Hide resolved
@rishabhpoddar rishabhpoddar merged commit bac45ad into 4.1 Jan 3, 2024
4 checks passed
@rishabhpoddar rishabhpoddar deleted the add-debug-logs branch January 3, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants