Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sessionscope fix #122

Merged
merged 2 commits into from
May 8, 2024
Merged

Sessionscope fix #122

merged 2 commits into from
May 8, 2024

Conversation

rishabhpoddar
Copy link
Member

Summary of change

The shouldDoInterceptionBasedOnUrl function now returns true if sessionTokenBackendDomain is a valid subdomain of the URL's domain. This aligns with the behavior of browsers when sending cookies to subdomains.

Related issues

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in lib/ts/version.ts
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.

Remaining TODOs for this PR

  • Item1
  • Item2

Copy link

github-actions bot commented May 8, 2024

size-limit report 📦

Path Size
lib/build/index.js 26.08 KB (0%)

@rishabhpoddar rishabhpoddar changed the base branch from 4.1 to 5.0 May 8, 2024 12:05
@rishabhpoddar rishabhpoddar merged commit aee9134 into 5.0 May 8, 2024
3 of 4 checks passed
@rishabhpoddar rishabhpoddar deleted the session-scope-fix branch May 8, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant