Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop dependency on django-database-locks #25

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Drop dependency on django-database-locks #25

merged 2 commits into from
Jul 16, 2024

Conversation

DDuarte
Copy link
Contributor

@DDuarte DDuarte commented Jul 16, 2024

django-database-locks can still be used by implementations by subclassing the run_bot command

django-database-locks can still be used by implementations by subclassing the
run_bot command
@DDuarte DDuarte requested a review from a team as a code owner July 16, 2024 17:58
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.

Project coverage is 55.63%. Comparing base (e33242c) to head (55fb78c).
Report is 1 commits behind head on main.

Files Patch % Lines
slackbot/management/commands/run_bot.py 0.00% 23 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
+ Coverage   55.23%   55.63%   +0.40%     
==========================================
  Files          10       10              
  Lines         277      275       -2     
==========================================
  Hits          153      153              
+ Misses        124      122       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Jul 16, 2024

@DDuarte DDuarte merged commit 60baeba into main Jul 16, 2024
5 of 6 checks passed
@DDuarte DDuarte deleted the drop_locks branch July 16, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant