Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove colons from log rotation file name(extension). #11

Merged
merged 1 commit into from
Apr 19, 2021

Conversation

sushichop
Copy link
Owner

This PR fixes #10 with small change.

@github-actions
Copy link

1 Warning
⚠️ The library files were changed, but the tests remained unmodified.
Consider updating or adding to the tests to match the library changes.

Generated by 🚫 Danger

@codecov
Copy link

codecov bot commented Apr 19, 2021

Codecov Report

Merging #11 (038c82f) into main (a19c3dc) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #11   +/-   ##
=======================================
  Coverage   97.73%   97.73%           
=======================================
  Files          10       10           
  Lines         398      398           
=======================================
  Hits          389      389           
  Misses          9        9           
Impacted Files Coverage Δ
Sources/Puppy/FileRotationLogger.swift 94.38% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a19c3dc...038c82f. Read the comment docs.

@sushichop sushichop merged commit 9b57f06 into main Apr 19, 2021
@sushichop sushichop deleted the PR/remove-colons branch April 19, 2021 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FileRotationLogger crashes when archiving full log files
1 participant