Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix access level issue for use as a library. #4

Merged
merged 1 commit into from
Oct 20, 2020
Merged

Conversation

sushichop
Copy link
Owner

No description provided.

@github-actions
Copy link

1 Warning
⚠️ The library files were changed, but the tests remained unmodified.
Consider updating or adding to the tests to match the library changes.

Generated by 🚫 Danger

@codecov
Copy link

codecov bot commented Oct 20, 2020

Codecov Report

Merging #4 into main will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main       #4   +/-   ##
=======================================
  Coverage   98.70%   98.71%           
=======================================
  Files          10       10           
  Lines         387      388    +1     
=======================================
+ Hits          382      383    +1     
  Misses          5        5           
Impacted Files Coverage Δ
Sources/Puppy/BaseLogger.swift 100.00% <100.00%> (ø)
Sources/Puppy/FileLogger.swift 98.18% <100.00%> (ø)
Sources/Puppy/FileRotationLogger.swift 95.45% <100.00%> (ø)
Sources/Puppy/Formatter.swift 100.00% <100.00%> (ø)
Sources/Puppy/LogLevel.swift 100.00% <100.00%> (ø)
Sources/Puppy/OSLogger.swift 100.00% <100.00%> (ø)
Sources/Puppy/Puppy.swift 100.00% <100.00%> (ø)
Sources/Puppy/PuppyLogHandler.swift 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5146ff...bf247d8. Read the comment docs.

@sushichop sushichop merged commit ebf3b35 into main Oct 20, 2020
@sushichop sushichop deleted the FIX/access-level branch October 20, 2020 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant