Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new API about FileHandle #7

Merged
merged 1 commit into from
Nov 19, 2020
Merged

Support new API about FileHandle #7

merged 1 commit into from
Nov 19, 2020

Conversation

sushichop
Copy link
Owner

No description provided.

@github-actions
Copy link

1 Warning
⚠️ The library files were changed, but the tests remained unmodified.
Consider updating or adding to the tests to match the library changes.

Generated by 🚫 Danger

@codecov
Copy link

codecov bot commented Nov 19, 2020

Codecov Report

Merging #7 (d5913e4) into main (345ec4e) will decrease coverage by 0.92%.
The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
- Coverage   98.71%   97.78%   -0.93%     
==========================================
  Files          10       10              
  Lines         388      406      +18     
==========================================
+ Hits          383      397      +14     
- Misses          5        9       +4     
Impacted Files Coverage Δ
Sources/Puppy/FileRotationLogger.swift 94.50% <81.25%> (-0.95%) ⬇️
Sources/Puppy/FileLogger.swift 94.28% <86.95%> (-3.90%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 345ec4e...d5913e4. Read the comment docs.

@sushichop sushichop merged commit 88b20f5 into main Nov 19, 2020
@sushichop sushichop deleted the PR/support-new-api branch November 19, 2020 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant