Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command label missing from kepler_process metrics #1519

Closed
vprashar2929 opened this issue Jun 12, 2024 · 0 comments · Fixed by #1520
Closed

Command label missing from kepler_process metrics #1519

vprashar2929 opened this issue Jun 12, 2024 · 0 comments · Fixed by #1520
Labels
kind/bug report bug issue

Comments

@vprashar2929
Copy link
Collaborator

What happened?

When Kepler is deployed using the latest the process metrics do not have command label.

Eg:

kepler_process_bpf_cpu_time_ms_total{container_id="system_processes", instance="kepler-metal:8888", job="metal", pid="0", source="bpf"} | 25485.504
kepler_process_bpf_cpu_time_ms_total{container_id="system_processes", instance="kepler-metal:8888", job="metal", pid="1", source="bpf"} | 6.741
kepler_process_bpf_cpu_time_ms_total{container_id="system_processes", instance="kepler-metal:8888", job="metal", pid="1084", source="bpf"} | 0.213
kepler_process_bpf_cpu_time_ms_total{container_id="system_processes", instance="kepler-metal:8888", job="metal", pid="1086", source="bpf"} | 0
kepler_process_bpf_cpu_time_ms_total{container_id="system_processes", instance="kepler-metal:8888", job="metal", pid="1123", source="bpf"}

What did you expect to happen?

command label should be present in the kepler_process metrics

How can we reproduce it (as minimally and precisely as possible)?

Deploy the latest Kepler using k8s or docker-compose and then check the label command in any kepler_process metric.

Anything else we need to know?

No response

Kepler image tag

latest

Kubernetes version

$ kubectl version
# paste output here

Cloud provider or bare metal

OS version

# On Linux:
$ cat /etc/os-release
# paste output here
$ uname -a
# paste output here

# On Windows:
C:\> wmic os get Caption, Version, BuildNumber, OSArchitecture
# paste output here

Install tools

Kepler deployment config

For on kubernetes:

$ KEPLER_NAMESPACE=kepler

# provide kepler configmap
$ kubectl get configmap kepler-cfm -n ${KEPLER_NAMESPACE}
# paste output here

# provide kepler deployment description
$ kubectl describe deployment kepler-exporter -n ${KEPLER_NAMESPACE}

For standalone:

put your Kepler command argument here

Container runtime (CRI) and version (if applicable)

Related plugins (CNI, CSI, ...) and versions (if applicable)

@vprashar2929 vprashar2929 added the kind/bug report bug issue label Jun 12, 2024
sthaha added a commit to sthaha/kepler that referenced this issue Jun 12, 2024
Process metrics was missing `command` label (command="") because of the
`pad` that got added to the bpf process_metrics_t in sustainable-computing-io#1481.

Fixes sustainable-computing-io#1519

Signed-off-by: Sunil Thaha <sthaha@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug report bug issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant