Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add regressor package for curvefit extension #1247

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

sunya-ch
Copy link
Collaborator

@sunya-ch sunya-ch commented Feb 22, 2024

This PR works on the issue #1244 for curvefit extension.
I introduce a new package called regressor to replace LinearRegressor.
LinearRegressor is moved into this package as well as other new functions from curvefit trainer (check kepler-model-server issue).

The notice point:

  • trainer name needed to specify to use other curvefit function (using already-exists TRAINER key defined under modelConfig).
  • linear regressor has different weight definition since it can support multiple metrics while curvefit won't.
  • Curvefit will use only a single feature value. This is defined in the weight scale.
  • For log function, need update curvefit (log func) and generate_spec  kepler-model-server#232 to merged first.

Signed-off-by: Sunyanan Choochotkaew sunyanan.choochotkaew1@ibm.com

Signed-off-by: Sunyanan Choochotkaew <sunyanan.choochotkaew1@ibm.com>
@sunya-ch
Copy link
Collaborator Author

sunya-ch commented Feb 22, 2024

Got this error after first golangci failed.

Screenshot 2024-02-22 at 23 34 49

It seems the problem of cache: golangci/golangci-lint-action#244.
May I add skip-pkg-cache: true to PR CI.

Now working on golangci fix.

Signed-off-by: Sunyanan Choochotkaew <sunyanan.choochotkaew1@ibm.com>
@rootfs
Copy link
Contributor

rootfs commented Feb 22, 2024

@sunya-ch @marceloamaral there are some lint warning (duplicate code). Let's merge the PR right now for 0.7.4 and remove the duplicate code (if still exists after pkg cache CI fix) in a follow up PR in 0.7.5

@rootfs rootfs merged commit 6b8d2be into sustainable-computing-io:main Feb 22, 2024
18 of 19 checks passed
@sunya-ch sunya-ch mentioned this pull request Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants