Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Grafana Cases into the Case Module #1453

Merged
merged 2 commits into from
May 20, 2024

Conversation

KaiyiLiu1234
Copy link
Collaborator

New Grafana Cases include the following metrics: kepler_process_platform_joules_total, kepler_process_package_joules_total, kepler_process_bpf_cpu_time_ms_total, kepler_process_bpf_page_cache_hit_total. These have been included in the Cases module.

Copy link

github-actions bot commented May 20, 2024

🤖 SeineSailor

Here's a concise summary of the pull request changes:

Summary: The "Include Grafana Cases into the Case Module" pull request introduces four new metrics for Grafana Cases (kepler_process_platform_joules_total, kepler_process_package_joules_total, kepler_process_bpf_cpu_time_ms_total, and kepler_process_bpf_page_cache_hit_total) and updates the Cases module to incorporate these metrics.

Key Modifications:

  • Added new entries to the RAW_PROM_QUERIES list for the additional metrics.
  • Updated the stress function for logging and display of validation results with updated query names and color formatting.

Impact on Codebase:

  • No changes to exported function signatures, global data structures, or variables.
  • No impact on the external interface or behavior of the code.

Observations/Suggestions:

  • The changes are well-contained within the Cases module and do not affect other parts of the codebase.
  • It would be beneficial to include additional tests to ensure the new metrics are correctly validated and displayed.
  • Consider adding documentation updates to reflect the new metrics and their usage in the Cases module.

@rootfs rootfs merged commit 1b93eb1 into sustainable-computing-io:main May 20, 2024
22 checks passed
vprashar2929 pushed a commit to openshift-power-monitoring/kepler that referenced this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants