Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose version label in kepler_build_info #1473

Merged

Conversation

sthaha
Copy link
Collaborator

@sthaha sthaha commented May 28, 2024

This commit adds a label - version to kepler_exporter_build_info metrics to expose the version of kepler installed on the machine / node.

kepler_exporter_build_info{branch="",goarch="amd64",goos="linux",goversion="go1.21.9",revision="unknown",tags="include_gcs,include_oss,containers_image_openpgp,gssapi,providerless,netgo,osusergo,libbp
f,linux,gpu",version="v0.7.10-30-g1c397ff00b72b-dirty"} 1

Fixes: #1449

This commit adds a `label` - `version` to `kepler_exporter_build_info`
metrics to expose the version of kepler installed on the machine / node.

Fixes: sustainable-computing-io#1449

Signed-off-by: Sunil Thaha <sthaha@redhat.com>
Copy link

github-actions bot commented May 28, 2024

🤖 SeineSailor

Here is a concise summary of the pull request changes:

Summary: This pull request updates the kepler_exporter_build_info metric to expose the version of Kepler, obtained from git describe, and includes version information in the linker flags (LDFLAGS) using github.com/prometheus/common/version.

Key Modifications:

  • Adds a new version label to the kepler_exporter_build_info metric.
  • Updates LDFLAGS to include version information from github.com/prometheus/common/version.

Impact: This change allows users to obtain the version of Kepler installed on the machine or node, enhancing observability and monitoring capabilities. No changes affect the external interface, behavior, or exported functions.

Observations/Suggestions: The change is well-contained and does not introduce any breaking changes. However, it would be beneficial to consider adding tests to verify the correctness of the version information exposed in the metric. Additionally, documenting the new version label in the metric's documentation would improve discoverability and usability.

@rootfs rootfs merged commit 244ae8b into sustainable-computing-io:main May 28, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose Kepler version in exported metric
4 participants