Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpf: fix the process parameter order to match the c and go code #1479

Merged

Conversation

marceloamaral
Copy link
Collaborator

fix the process parameter order to match the c and go code

Signed-off-by: marceloamaral <marcelo.amaral1@ibm.com>
Copy link

github-actions bot commented May 30, 2024

🤖 SeineSailor

Here is a concise summary of the pull request changes:

Summary: This PR fixes the parameter order inconsistency in the ProcessBPFMetrics struct between C and Go code, ensuring uniformity and maintaining codebase consistency.

Key Modifications:

  • Adjusted ThreadPID and PID parameters in the ProcessBPFMetrics struct to match the C implementation.

Impact: Although internal, this change promotes smoother interaction and maintenance between C and Go implementations, avoiding potential confusion.

Observations/Suggestions: None, as this change is a straightforward fix to maintain consistency.

@marceloamaral marceloamaral merged commit bdd44b1 into sustainable-computing-io:main May 30, 2024
22 checks passed
@marceloamaral
Copy link
Collaborator Author

related to PR #1468

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant