Merge pull request #118 from suusan2go/issue_117

fill CharSequence param as String
suusan2go · Jul 29, 2023 · ecef6f9 · ecef6f9
2 parents 6022031 + 9468a2e
commit ecef6f9
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 8 deletions.
diff --git a/src/main/kotlin/com/github/suusan2go/kotlinfillclass/inspections/BaseFillClassInspection.kt b/src/main/kotlin/com/github/suusan2go/kotlinfillclass/inspections/BaseFillClassInspection.kt
@@ -328,7 +328,9 @@ open class FillClassFix(
 
             KotlinBuiltIns.isCollectionOrNullableCollection(type) -> "arrayOf()"
             KotlinBuiltIns.isNullableAny(type) -> "null"
-            KotlinBuiltIns.isString(type) -> "\"\""
+            KotlinBuiltIns.isCharSequence(type) ||
+                KotlinBuiltIns.isString(type) -> "\"\""
+
             KotlinBuiltIns.isListOrNullableList(type) -> "listOf()"
             KotlinBuiltIns.isSetOrNullableSet(type) -> "setOf()"
             KotlinBuiltIns.isMapOrNullableMap(type) -> "mapOf()"

diff --git a/...main/kotlin/com/github/suusan2go/kotlinfillclass/inspections/FillDummyValuesInspection.kt b/...main/kotlin/com/github/suusan2go/kotlinfillclass/inspections/FillDummyValuesInspection.kt
@@ -72,7 +72,9 @@ class FillDummyValueFix(
                 KotlinBuiltIns.isLong(type) ||
                 KotlinBuiltIns.isShort(type) -> "${ValueGenerator.randomNumFor(paramName)}"
 
-            KotlinBuiltIns.isString(type) -> "\"${ValueGenerator.randomStringFor(paramName)}\""
+            KotlinBuiltIns.isCharSequence(type) ||
+                KotlinBuiltIns.isString(type) -> "\"${ValueGenerator.randomStringFor(paramName)}\""
+
             else -> super.fillValue(descriptor)
         }
     }

diff --git a/...t/kotlin/com/github/suusan2go/kotlinfillclass/inspections/FillDummyValueInspectionTest.kt b/...t/kotlin/com/github/suusan2go/kotlinfillclass/inspections/FillDummyValueInspectionTest.kt
@@ -24,17 +24,18 @@ class FillDummyValueInspectionTest : BasePlatformTestCase() {
     fun `test fill class constructor`() {
         every { ValueGenerator.randomStringFor("name") } returns "John Smith"
         every { ValueGenerator.randomNumFor("age") } returns 1234
+        every { ValueGenerator.randomStringFor("pass") } returns "password"
         doAvailableTest(
             """
-            class User(val name: String, val age: Int)
+            class User(val name: String, val age: Int, val pass: CharSequence)
             fun test() {
                 User(<caret>)
             }
         """,
             """
-            class User(val name: String, val age: Int)
+            class User(val name: String, val age: Int, val pass: CharSequence)
             fun test() {
-                User(name = "John Smith", age = 1234)
+                User(name = "John Smith", age = 1234, pass = "password")
             }
         """,
         )

diff --git a/...t/kotlin/com/github/suusan2go/kotlinfillclass/inspections/FillEmptyValueInspectionTest.kt b/...t/kotlin/com/github/suusan2go/kotlinfillclass/inspections/FillEmptyValueInspectionTest.kt
@@ -10,15 +10,15 @@ class FillEmptyValueInspectionTest : BasePlatformTestCase() {
     fun `test fill class constructor`() {
         doAvailableTest(
             """
-            class User(val name: String, val age: Int)
+            class User(val name: String, val age: Int, val pass: CharSequence)
             fun test() {
                 User(<caret>)
             }
         """,
             """
-            class User(val name: String, val age: Int)
+            class User(val name: String, val age: Int, val pass: CharSequence)
             fun test() {
-                User(name = "", age = 0)
+                User(name = "", age = 0, pass = "")
             }
         """,
         )