-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #100, #101 #102
Fix #100, #101 #102
Conversation
@t-kameyama I have noticed that incorrect completion is made in single cases. Could you please correct it? |
val parameters = functions[selectedValue]?.valueParameters.orEmpty() | ||
CommandProcessor.getInstance().runUndoTransparentAction { | ||
runWriteAction { | ||
argumentList.fillArguments(parameters, editor) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm having the same problem as #85 because of missing lambdaArgument
.
Could you add lambdaArgument
argument to createListPopup
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I am not sure of the reproduction conditions, but I have confirmed that the completion is filled without a selector being displayed, even though there is an overload function. I will let you know if I can find the reproduction conditions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have checked and found some issues with compatibility with older versions of IDEA. In order for this plugin to support Android Studio, we need to continue to use some classes that are deprecated. Please change the package of the classes and functions you use according to the table below.
before | after |
---|---|
org.jetbrains.kotlin.idea.base.fe10.codeInsight.newDeclaration.Fe10KotlinNameSuggester | org.jetbrains.kotlin.idea.core.KotlinNameSuggester |
org.jetbrains.kotlin.idea.base.psi.textRangeIn | org.jetbrains.kotlin.idea.util.textRangeIn |
org.jetbrains.kotlin.idea.codeinsight.api.classic.inspections.AbstractKotlinInspection | org.jetbrains.kotlin.idea.inspections.AbstractKotlinInspection |
org.jetbrains.kotlin.idea.codeinsight.utils.findExistingEditor | org.jetbrains.kotlin.idea.inspections.findExistingEditor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change, LGTM!
Fixes #100
fb3dc20
Fixes #101
77b1ffc