Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #100, #101 #102

Merged
merged 7 commits into from
Jun 16, 2023
Merged

Fix #100, #101 #102

merged 7 commits into from
Jun 16, 2023

Conversation

t-kameyama
Copy link
Contributor

@t-kameyama t-kameyama commented May 15, 2023

Fixes #100

fb3dc20

スクリーンショット 2023-05-15 16 35 11 スクリーンショット 2023-05-15 16 35 21 スクリーンショット 2023-05-15 16 35 30

Fixes #101

77b1ffc

@oboenikui
Copy link
Collaborator

@t-kameyama
Thanks for great PR!

I have noticed that incorrect completion is made in single cases. Could you please correct it?

val parameters = functions[selectedValue]?.valueParameters.orEmpty()
CommandProcessor.getInstance().runUndoTransparentAction {
runWriteAction {
argumentList.fillArguments(parameters, editor)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm having the same problem as #85 because of missing lambdaArgument.

Could you add lambdaArgument argument to createListPopup ?

Copy link
Contributor Author

@t-kameyama t-kameyama Jun 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oboenikui
Copy link
Collaborator

Also, I am not sure of the reproduction conditions, but I have confirmed that the completion is filled without a selector being displayed, even though there is an overload function. I will let you know if I can find the reproduction conditions.

Copy link
Collaborator

@oboenikui oboenikui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@t-kameyama

I have checked and found some issues with compatibility with older versions of IDEA. In order for this plugin to support Android Studio, we need to continue to use some classes that are deprecated. Please change the package of the classes and functions you use according to the table below.

before after
org.jetbrains.kotlin.idea.base.fe10.codeInsight.newDeclaration.Fe10KotlinNameSuggester org.jetbrains.kotlin.idea.core.KotlinNameSuggester
org.jetbrains.kotlin.idea.base.psi.textRangeIn org.jetbrains.kotlin.idea.util.textRangeIn
org.jetbrains.kotlin.idea.codeinsight.api.classic.inspections.AbstractKotlinInspection org.jetbrains.kotlin.idea.inspections.AbstractKotlinInspection
org.jetbrains.kotlin.idea.codeinsight.utils.findExistingEditor org.jetbrains.kotlin.idea.inspections.findExistingEditor

Copy link
Collaborator

@oboenikui oboenikui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change, LGTM!

@oboenikui oboenikui merged commit bccc40b into suusan2go:master Jun 16, 2023
@t-kameyama t-kameyama deleted the issue_100 branch June 16, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't fill varargs Support overloaded functions
2 participants