Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: en_us locale causes leakage of ScriptableObject #138

Merged
merged 1 commit into from
May 22, 2024
Merged

fix: en_us locale causes leakage of ScriptableObject #138

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Packages/jp.suzuryg.face-emo/Editor/Detail/Localization/LocalizationSetting.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ public class LocalizationSetting : IReadOnlyLocalizationSetting, ILocalizationSe

private Subject<LocalizationTable> _onTableChanged = new Subject<LocalizationTable>();

private static LocalizationTable en_us;

public LocalizationSetting()
{
var locale = GetLocale();
Expand Down Expand Up @@ -87,7 +89,9 @@ public static LocalizationTable GetTable(Locale locale)
else
{
// en_US has the table in source code, not asset.
return ScriptableObject.CreateInstance<LocalizationTable>();
en_us = en_us != null ? en_us : ScriptableObject.CreateInstance<LocalizationTable>();

return en_us;
}
}

Expand Down
Loading