Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate build install readme #105

Merged
merged 11 commits into from
Aug 9, 2021
Merged

Conversation

shimwell
Copy link
Member

As discussed in the DAGMC community meeting today.

The Readme contains more advanced build instructions that the average user will not need.

Therefore the README has been split into two parts, one for simple installation and one for the more complex build.

The testing section was also in need on a split and the more advanced part of the testing is has been moved to the test_plugin folder where it will render as the main readme for that url

Just worth mentioning that the README files have links between them which will not work on this PR as they link to the develop branch version of themselves :-)

Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this rolling, @shimwell. I'll rely on others to confirm all the build details in the dev readme are correct.

README.md Outdated Show resolved Hide resolved
<summary><b>Expand</b> - Ubuntu terminal commands for Ubuntu 20.04</summary>
<pre><code class="language-html">
wget https://github.com/svalinn/Cubit-plugin/releases/download/0.1.0/svalinn-plugin_ubuntu-20.04_cubit_2021.5.tgz
sudo tar -xzvf svalinn-plugin_ubuntu-20.04_cubit_2021.5.tgz -C /opt/Coreform-Cubit-2021.5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only valid for Ubuntu, I think.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep I think so also, it mentions Ubuntu usage in the Expansion tab.

I did this via an expand tabs as I think we could have expand tabs for every OS once they are all working.

README_dev.md Outdated Show resolved Hide resolved
shimwell and others added 2 commits July 22, 2021 17:13
Co-authored-by: Paul Wilson <paul.wilson@wisc.edu>
…bit-plugin into separate_build_install_readme
@bam241
Copy link
Member

bam241 commented Jul 23, 2021

Those failing test should not hold the merge of this as it is documentation change only

Copy link
Member

@bam241 bam241 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM! thx @shimwell

Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shimwell - Better to use relative paths so that when we look at the rendered PR we can follow the right links

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README_dev.md Outdated Show resolved Hide resolved
Co-authored-by: Paul Wilson <paul.wilson@wisc.edu>
Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a couple of additional issues

README_dev.md Outdated Show resolved Hide resolved
README_dev.md Outdated Show resolved Hide resolved
shimwell and others added 2 commits July 23, 2021 15:19
Co-authored-by: Paul Wilson <paul.wilson@wisc.edu>
README_dev.md Show resolved Hide resolved
README_dev.md Outdated Show resolved Hide resolved
Co-authored-by: Baptiste Mouginot <15145274+bam241@users.noreply.github.com>
README.md Outdated
@@ -243,32 +64,22 @@ Cubit>

If this output does not appear, then the plugin was not installed correctly.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not true on MacOS with Cubit 2021.5

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here is my command input:

Finished Command: undo on

Cubit>help dagmc

Help for words: dagmc.

export dagmc <filename> [faceting_tolerance <faceting tolerance>] [length_tolerance <length tolerance>]
     [normal_tolerance <normal tolerance>] [make_watertight] [verbose]
     [fatal_on_curves]


Help for words: dagmc.

export dagmc <filename> [faceting_tolerance <faceting tolerance>] [length_tolerance <length tolerance>]
     [normal_tolerance <normal tolerance>] [make_watertight] [verbose]
     [fatal_on_curves]

Cubit>

not Loaded Svalinn plugin input but help dagmc worked just fine

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok I can perhaps change it to something like ...

Run coreform_cubit from the command line. After the Cubit GUI finishes loading, run the following command in the Cubit command line:

help dagmc

If the plugin was installed correctly you should see the following text appear.

Help for words: dagmc.

export dagmc <filename> [faceting_tolerance <faceting tolerance>] [length_tolerance <length tolerance>]
     [normal_tolerance <normal tolerance>] [make_watertight] [verbose]
     [fatal_on_curves]

If this output does not appear, then the plugin was not installed correctly.

@shimwell
Copy link
Member Author

shimwell commented Aug 9, 2021

Perhaps this documentation update is ready to merge

@gonuke
Copy link
Member

gonuke commented Aug 9, 2021

Thanks @shimwell - This one is definitely ready to merge! (documentation is asymptotic - we can always find things to tweak, and then PR's languish)

@gonuke gonuke merged commit 01a1751 into develop Aug 9, 2021
@shimwell shimwell deleted the separate_build_install_readme branch August 9, 2021 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants