Automatic download and build of MOAB #969

bam241 · 2024-12-04T20:25:45Z

Description

Add capability to automate pull and build MOAB at DAGMC building time

This is redondant with #964

Motivation and Context

This is part of the project from @shimwell on getting a pip install for OpenMC with DAGMC.

Changes

tweaked a little bit the findMOAB.cmake

add a make files that contains the proper ExternalProject configuration
add a CMAKE variable to enable pull and build and change the dips and link for the other DAGMC library

Behavior

Nothing changes if DDL_DEPS is not set at ON on Cmake configuration.
Otherwise pull build MOAB from MOAB repo builds it, and build the DAGMC lib against it.

Changelog file

Done

This is very much inspired by @ahnaf-tahmid-chowdhury work on PyNE cmake.

This works is sponsored by Proxima Fusion

bam241 · 2024-12-04T20:29:51Z

@ahnaf-tahmid-chowdhury @shimwell @gonuke even if this is still a draft, feel free to provide any feed back!

src/pyne/CMakeLists.txt

src/dagmc/CMakeLists.txt

bam241 · 2024-12-04T20:32:36Z

cmake/FindMOAB.cmake

+else()
+  # message(FATAL_ERROR "Could not find MOAB")


This should still return a fatal_error if ExternalProject encounters an issue

bam241 · 2024-12-04T20:34:14Z

The safeguard I added should be improve... (i.e.: have them only MOAB download is triggered...)

cmake/FindMOAB.cmake

bam241 · 2024-12-06T06:55:21Z

@gonuke this still needs some polishing here and there, but I think this is ready for a first opinion.

change location cmake up cmake up cmake up CMAKE_MODULE_PATH CMAKE_MODULE_PATH CMAKE_MODULE_PATH adding LIBS adding LIBS install_dependent_library(MOAB ) install_dependent_library adding LIBS adding LIBS adding LIBS adding LIBS adding LIBS adding LIBS adding LIBS adding LIBS instal_prefix instal_prefix instal_prefix instal_prefix instal_prefix instal_prefix instal_prefix instal_prefix instal_prefix instal_prefix INTERFACE INTERFACE INTERFACE INTERFACE INTERFACE INTERFACE INTERFACE INTERFACE INTERFACE INTERFACE INTERFACE INTERFACE INTERFACE INTERFACE tmp get the safeguard revert unnecessary change

Co-authored-by: Jonathan Shimwell <drshimwell@gmail.com>

ahnaf-tahmid-chowdhury

Thank you very much for the update. I have a few comments for improvement.

cmake/DAGMC_macros.cmake

cmake/MOAB_PullAndMake.cmake

ahnaf-tahmid-chowdhury · 2024-12-06T12:19:53Z

cmake/MOAB_PullAndMake.cmake

+        -DBUILD_SHARED_LIBS:BOOL=ON
+        -DENABLE_HDF5:BOOL=ON
+        -DHDF5_ROOT:PATH=${HDF5_ROOT}
+        -DCMAKE_INSTALL_RPATH=${HDF5_ROOT}/lib:${MOAB_INSTALL_PREFIX}/lib


This method may work here for now, but may create trouble while working with scikit-build-core depended project. However, I am not sure here.

I have no experience about scikit-build-core, maybe we shall fix it, if the problem occurs ?

I believe MOAB master branch now has scikit-build core while version 5.5.1 does not.

Perhaps changing the moab version to master would provide a quick way of checking if this continues to work

GIT_REPOSITORY https://bitbucket.org/fathomteam/moab.git GIT_TAG ${moab_version}

Trying it now.

Just to mention @bam241 tried this with the master branch of MOAB (which has scikit build core) and reported that it works

have a doubt about what I did, I'll try one more time

ahnaf-tahmid-chowdhury · 2024-12-06T12:21:00Z

.github/workflows/linux_build_test.yml

@@ -50,6 +50,9 @@ jobs:
          5.4.1,
          5.5.1,
        ]
+        ddl_deps : [


What is the use of it?

This is like Enable Download MOAB or Double Down?

this only enables MOAB Download, otherwise everything work as it used to.

I don't have a strong opinion about the name of the variable,
but eventually one might want to include Embree and DD the same way...

if your question is about the addition into the matrix, I needed it to allow the CI to test for this kind of build...

this seems to pass, I'll revert the change

jon-proximafusion · 2024-12-10T12:19:18Z

Testing locally with this docker file and it compiles for me
Note this points to Bam's fork and this PR branch
Also note, this example is very minimal with no DD, Embree, Pyne

FROM ubuntu:24.04

RUN apt-get update -y
RUN apt-get install git cmake libhdf5-serial-dev g++ libeigen3-dev -y 

RUN mkdir DAGMC && \
	cd DAGMC && \
	git clone --single-branch --branch auto_moab --depth 1 https://github.com/bam241/DAGMC.git && \
	mkdir build && \
	cd build && \
	cmake ../DAGMC -DBUILD_TALLY=ON \
                   -DBUILD_STATIC_EXE=OFF \
                   -DBUILD_STATIC_LIBS=OFF \
                   -DCMAKE_INSTALL_PREFIX=/DAGMC/ \
                   -DBUILD_UWUW=OFF \
                   -DDDL_INSTALL_DEPS=ON && \
	make -j install

cmake/MOAB_PullAndMake.cmake

bam241 · 2024-12-12T11:08:30Z

Test on 5fe643b
checked the proper work of this against MOAB Master branch

bam241 commented Dec 4, 2024

View reviewed changes

src/pyne/CMakeLists.txt Outdated Show resolved Hide resolved

bam241 commented Dec 4, 2024

View reviewed changes

src/dagmc/CMakeLists.txt Outdated Show resolved Hide resolved

bam241 commented Dec 4, 2024

View reviewed changes

jon-proximafusion mentioned this pull request Dec 5, 2024

updated cmake min version to 3.18 #970

Open

shimwell reviewed Dec 5, 2024

View reviewed changes

cmake/FindMOAB.cmake Outdated Show resolved Hide resolved

shimwell reviewed Dec 5, 2024

View reviewed changes

cmake/FindMOAB.cmake Outdated Show resolved Hide resolved

bam241 force-pushed the auto_moab branch from 8761cb8 to c20a90e Compare December 6, 2024 05:31

bam241 marked this pull request as ready for review December 6, 2024 06:42

bam241 requested a review from gonuke December 6, 2024 06:54

bam241 force-pushed the auto_moab branch from 79afbbc to d49d208 Compare December 6, 2024 11:20

bam241 and others added 4 commits December 6, 2024 12:30

Update cmake/FindMOAB.cmake

fa05e11

Co-authored-by: Jonathan Shimwell <drshimwell@gmail.com>

Update cmake/FindMOAB.cmake

21343f9

Co-authored-by: Jonathan Shimwell <drshimwell@gmail.com>

reformating + changelog + tests

45feb89

bam241 force-pushed the auto_moab branch from d49d208 to 45feb89 Compare December 6, 2024 11:32

add missing indent

615b955

ahnaf-tahmid-chowdhury reviewed Dec 6, 2024

View reviewed changes

bam241 added 3 commits December 6, 2024 13:55

generalyze shared lib extention

26abadb

temporary change to master

8c05ac7

back to 5.5.1

24ed342

jon-proximafusion reviewed Dec 12, 2024

View reviewed changes

cmake/MOAB_PullAndMake.cmake Outdated Show resolved Hide resolved

jon-proximafusion reviewed Dec 12, 2024

View reviewed changes

cmake/MOAB_PullAndMake.cmake Outdated Show resolved Hide resolved

bam241 added 2 commits December 12, 2024 11:56

adding DDL_INSTALL_DEPS as an option with default to OFF

85564ea

keeping jon changes

17d11d1

bam241 force-pushed the auto_moab branch from 4be94aa to 17d11d1 Compare December 12, 2024 10:58

trying MOAB master

5fe643b

reverting to 5.5.1 as default version for MOAB

92a2a0e

shimwell mentioned this pull request Dec 12, 2024

Fetch DAGMC if not found in cmakelists.txt openmc-dev/openmc#3193

Draft

5 tasks

cleaning variable name

b86a8a6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Automatic download and build of MOAB #969

Automatic download and build of MOAB #969

bam241 commented Dec 4, 2024 •

edited

Loading

bam241 commented Dec 4, 2024

bam241 Dec 4, 2024

bam241 commented Dec 4, 2024 •

edited

Loading

bam241 commented Dec 6, 2024

ahnaf-tahmid-chowdhury left a comment

ahnaf-tahmid-chowdhury Dec 6, 2024

bam241 Dec 6, 2024

shimwell Dec 6, 2024

bam241 Dec 6, 2024

jon-proximafusion Dec 12, 2024

bam241 Dec 12, 2024

ahnaf-tahmid-chowdhury Dec 6, 2024

ahnaf-tahmid-chowdhury Dec 6, 2024

bam241 Dec 6, 2024

bam241 Dec 6, 2024

bam241 Dec 6, 2024

jon-proximafusion commented Dec 10, 2024 •

edited

Loading

bam241 commented Dec 12, 2024

Automatic download and build of MOAB #969

Are you sure you want to change the base?

Automatic download and build of MOAB #969

Conversation

bam241 commented Dec 4, 2024 • edited Loading

Description

Motivation and Context

Changes

Behavior

Changelog file

bam241 commented Dec 4, 2024

Choose a reason for hiding this comment

bam241 commented Dec 4, 2024 • edited Loading

bam241 commented Dec 6, 2024

ahnaf-tahmid-chowdhury left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jon-proximafusion commented Dec 10, 2024 • edited Loading

bam241 commented Dec 12, 2024

bam241 commented Dec 4, 2024 •

edited

Loading

bam241 commented Dec 4, 2024 •

edited

Loading

jon-proximafusion commented Dec 10, 2024 •

edited

Loading