Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close file handle #21

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

GPSHansl
Copy link

@GPSHansl GPSHansl commented Oct 5, 2022

closing file handle allows renaming of file on windows
the final filename timestamp will no longer contain ":" chars
use own dialect to allow "semicolons"

@svalouch
Copy link
Owner

svalouch commented Oct 3, 2023

Ah, Windows.

I'm okay changing the file handling to use close() and in principle also changing the file name to be valid on NTFS, but that would be a breaking change and I'm not planning on a release. That being said, it's broken on windows. I'll think about it.

But what's the reasoning behind changing the delimiter? Most tools allow you to specify which is used for reading, so this seems unnecessary to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants