Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(create): Resolve package manager commands correctly in next steps #360

Merged
merged 2 commits into from
Dec 23, 2024

Conversation

AdrianGonz97
Copy link
Member

closes #359

Copy link

pkg-pr-new bot commented Dec 16, 2024

Open in Stackblitz

npm i https://pkg.pr.new/sveltejs/cli/sv@360
npm i https://pkg.pr.new/sveltejs/cli/svelte-migrate@360

commit: 0ebdd0d

Copy link

changeset-bot bot commented Dec 16, 2024

🦋 Changeset detected

Latest commit: 0ebdd0d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sv Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@manuel3108 manuel3108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH, I did not manage to test the deno specific case, as the cli is never showing deno in the next steps for me. But since this is also happening with the latest release, this seems to be a setup problem on my side.

I managed to confirm that the calls for pnpm and npm are printed correctly, so this should be fine.

@manuel3108 manuel3108 merged commit b25077c into main Dec 23, 2024
8 checks passed
@manuel3108 manuel3108 deleted the fix/create-deno-next-step branch December 23, 2024 06:56
@github-actions github-actions bot mentioned this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo: deno dev --open instead of deno task dev --open
2 participants