-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
svelte-check error printed to console #1988
Comments
Hmm. It seems to be choking on the empty file: |
@dummdidumm I might need your help with this one. I can't figure out how to get I can't change the file to make it a valid one because the test is testing for an invalid file |
Since he's on vacation, is there anything I can help with on the language-tools side? This error it's logged with The ignore flag currently only affects the source file diagnostic. And the config loading is run before all the diagnostics without considering the ignored path. I think it makes sense to not search for config files in ignored paths. But since this is more of "annoying" behaviour. I think we can have more discussion and considering before fix this. |
Oh, right. I forgot he was away It's just annoying as you said and so not very high priority It's not printed when running the test (or if it is it's lost in the other output), but rather when running Considering |
Can't we add an empty |
Narrowing down the config files, I found the suspecting error to come from https://github.com/sveltejs/kit/blob/master/packages/kit/src/core/config/test/fixtures/export-missing/svelte.config.js Edit: It was already pointed out above, but I meant to say that it was deliberately made empty, so adding an empty export would probably defeat the purpose. Maybe we could just omit this one test or ignore the config folder just like the make_package tests. As for the current ignored paths, that might be a good idea, we could add those empty exports and adjust the package.json as well to have type module. |
I just upgraded Still, I don't know how to remove this warning since the file is purposefully malformed for testing purposes. I suppose if config loading got moved to its own package we wouldn't have to run |
Some technical background why this all is so hard to tackle:
|
I wonder if we should just remove that specific test |
I wouldn't mind that as a solution. It doesn't seem like the most important thing to have |
Describe the bug
svelte-check seems to be looking for a
svelte.config.js
file perhaps and then spitting out an error when it can't find it?Reproduction
cd packages/kit
pnpm check
Logs
System Info
kit `master`
Severity
annoyance
Additional Information
No response
The text was updated successfully, but these errors were encountered: