Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[svelte-check] --ignore flag gets overwritten by --tsconfig #1074

Closed
macmillen opened this issue Jun 24, 2021 · 2 comments
Closed

[svelte-check] --ignore flag gets overwritten by --tsconfig #1074

macmillen opened this issue Jun 24, 2021 · 2 comments
Labels
bug Something isn't working Fixed Fixed in master branch. Pending production release.

Comments

@macmillen
Copy link

Describe the bug
When i use both --ignore and --tsconfig flags in the svelte-check cli, the --ignore flag doesn't do anything anymore. It only works when I omit the --tsconfig flag.

To Reproduce

yarn svelte-check --ignore "src" --tsconfig ./tsconfig.json

Expected behavior
If that's expected throw a warning or something to make the user aware. Otherwise it should work with both flags.

@macmillen macmillen added the bug Something isn't working label Jun 24, 2021
@dummdidumm
Copy link
Member

dummdidumm commented Jun 25, 2021

It's expected, the tsconfig exclude setting should be used in that case. Throwing might make sense. There's still a slight difference in watch mode: Those in --ignore are not watched for changes. Omitting it could mean too many files are watched, which means we would need to adjust the watcher to specifically watch all files that are loaded (transitively) through the tsconfig.

@dummdidumm
Copy link
Member

In svelte-check, setting both will be an error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Fixed Fixed in master branch. Pending production release.
Projects
None yet
Development

No branches or pull requests

2 participants