Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify of any breaking changes to make it easier for folks to update their apps #3710

Closed
kevmodrome opened this issue Feb 3, 2022 · 4 comments

Comments

@kevmodrome
Copy link

kevmodrome commented Feb 3, 2022

Describe the problem

There have been some requests for a way to get notified of breaking changes in kit. I'd argue we wouldn't need to care about it until 1.0 but I'm forwarding the request anyway.

Describe the proposed solution

A quick way to solve this would be to add some kind of (breaking change) message in the changeset. Using #3670 as an example: Add App namespace for app-level types (breaking change).

Alternatives considered

  • Do nothing

Importance

nice to have

Additional Information

  • None
@kevmodrome kevmodrome changed the title Notify of any breaking changes Notify of any breaking changes to make it easier for folks update their apps Feb 3, 2022
@dominikg
Copy link
Member

dominikg commented Feb 3, 2022

there is breaking change which highlights at least some

@Conduitry
Copy link
Member

We've been inconsistent about including "breaking change" next to changelog entries. It would probably be a polite thing to do,

@kevmodrome kevmodrome changed the title Notify of any breaking changes to make it easier for folks update their apps Notify of any breaking changes to make it easier for folks to update their apps Feb 3, 2022
@bluwy
Copy link
Member

bluwy commented Feb 7, 2022

We do have the Breaking: text in the changeset to note it's a breaking change. But yes it seems like some breaking changes are not prefixed with it, e.g. #3674 too

@Rich-Harris
Copy link
Member

We're getting better about adding [breaking] to changesets. I think that's probably the best we can do until we hit stable, so I'll close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants