-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove target
option
#3674
Remove target
option
#3674
Conversation
🦋 Changeset detectedLatest commit: 2b61a31 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✔️ Deploy Preview for kit-demo canceled. 🔨 Explore the source changes: 2b61a31 🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/61fa8c18eb542c000770f1b9 |
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
Ref #2221. This simplifies
svelte.config.js
andsrc/app.html
, and removes the tight coupling between them, by getting rid of thetarget
option. Instead, the init script hydrates the init script'sparentNode
. As a bonus, it makes it easier to embed multiple SvelteKit apps on a single page, for the rare cases where that's necessary.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpx changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0