Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[A11y] Use aria-current="page" for the page menu in create-svelte template #7353

Closed
Tal500 opened this issue Oct 22, 2022 · 0 comments · Fixed by #7376
Closed

[A11y] Use aria-current="page" for the page menu in create-svelte template #7353

Tal500 opened this issue Oct 22, 2022 · 0 comments · Fixed by #7376

Comments

@Tal500
Copy link
Contributor

Tal500 commented Oct 22, 2022

Describe the problem

It is better to use aria-current on the main page menu for accessibility, to specify what page is the current one (and the one that is the current, should be with aria-current="page").

A good side effect is that we can use the aria-current="page" as a CSS selector to style the currently active page item.

Describe the proposed solution

Use aria-current.

In Sapper demo, everything I have just said is implemented in the old Nav component, but why not in SvelteKit demos?

Alternatives considered

Not doing this :-(

Importance

nice to have

Additional Information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants