-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: server js fallthrough to page if handler doesn't exist #10121
Conversation
🦋 Changeset detectedLatest commit: a176653 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to merge master in, master contains some changes which adjusts response
after the if/else chain which would no longer apply.
|
||
// If endpoint doesn't have a handler for these methods, fall back to the page | ||
if ( | ||
response.status === 405 && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you mean for this to be 405
? based on the comment I would have expected 404
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think it's 405
. Kit responds with 405 method not allowed
when the method handler isn't found.
@gtm-nayan it looks like this PR still needs a rebase |
Through #11256 the underlying issue of conflicting routes was fixed, and as such this PR is no longer necessary - closing. |
closes #10102
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.