Fix default $error.svelte page
#1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conduitry
reviewed
Apr 14, 2021
benmccann
reviewed
Apr 14, 2021
Conduitry
approved these changes
Apr 14, 2021
Merged
zhammer
added a commit
to zhammer/writing
that referenced
this pull request
Jun 14, 2021
zhammer
added a commit
to zhammer/writing
that referenced
this pull request
Jun 14, 2021
* fix __error.svelte sveltejs/kit#1021 * properly handle trailing slashes i think this may be a bug i should report to svelte-kit; the static-adapter doesn't properly handle redirecting away from trailing slash on safari
bfanger
pushed a commit
to bfanger/kit
that referenced
this pull request
Oct 18, 2021
Usage:
```json
kit: {
prerender: {
subfolders: false,
},
```
Setting the kit.prerender.subfolders setting to false (default is true) will change the filename generation from "/about/index.html" to "/about.html"
Inspiration for the `subfolders` name came from nuxt:
https://nuxtjs.org/docs/configuration-glossary/configuration-generate/#subfolders
- Fixes sveltejs#1443,
- Related to sveltejs#2276, [sapper/sveltejs#1021](sveltejs/sapper#1021)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently you get
Cannot read property 'message' of undefinedwith the default error page, as the props are no longer passed in by default.