Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct line numbers when console logging stack traces #10769

Merged
merged 6 commits into from
Sep 24, 2023

Conversation

eltigerchino
Copy link
Member

@eltigerchino eltigerchino commented Sep 22, 2023

fixes #10138

This PR fixes the server stack trace by mutating the error object with vite.ssrFixStacktrace rather than using a Proxy. It also fixes the stack trace output by Vite in the server logs and the vite HMR overlay by passing in the option when loading user code as SSR modules.

Thanks to @dmoebius we know that console.log, etc. bypasses proxies (for some strange reason). We can also safely use vite.ssrFixStacktrace without worrying about repeatedly fixing the same error object because it memoizes the error objects fixed. This optimisation wasn't available when vite.rewriteStacktrace was first exposed (but it has been now for some time!).

No test because I can't figure out how to capture the output of console.log and Vite's own messages.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot
Copy link

changeset-bot bot commented Sep 22, 2023

🦋 Changeset detected

Latest commit: b29758b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@eltigerchino eltigerchino changed the title fix: use vite.ssrFixStacktrace instead of vite.rewriteStacktrace with Proxy fix: correct line numbers when console logging stack traces Sep 22, 2023
@benmccann
Copy link
Member

another PR related to fixing stack traces: #10638

because it later loads the hooks file where the user may have errors
vite stopped doing it automatically some point I guess
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong line numbers in stacktraces in dev mode on console, in IntelliJ/WebStorm and VSCode
3 participants