-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correct line numbers when console logging stack traces #10769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b29758b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
eltigerchino
changed the title
fix: use
fix: correct line numbers when console logging stack traces
Sep 22, 2023
vite.ssrFixStacktrace
instead of vite.rewriteStacktrace
with Proxy
another PR related to fixing stack traces: #10638 |
because it later loads the hooks file where the user may have errors
vite stopped doing it automatically some point I guess
gtm-nayan
reviewed
Sep 24, 2023
gtm-nayan
approved these changes
Sep 24, 2023
Merged
5 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #10138
This PR fixes the server stack trace by mutating the error object with
vite.ssrFixStacktrace
rather than using a Proxy. It also fixes the stack trace output by Vite in the server logs and the vite HMR overlay by passing in the option when loading user code as SSR modules.Thanks to @dmoebius we know that
console.log
, etc. bypasses proxies (for some strange reason). We can also safely usevite.ssrFixStacktrace
without worrying about repeatedly fixing the same error object because it memoizes the error objects fixed. This optimisation wasn't available whenvite.rewriteStacktrace
was first exposed (but it has been now for some time!).No test because I can't figure out how to capture the output of
console.log
and Vite's own messages.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.