Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear paths config on svelte-kit preview #1155

Closed
wants to merge 5 commits into from
Closed

Clear paths config on svelte-kit preview #1155

wants to merge 5 commits into from

Conversation

Rich-Harris
Copy link
Member

#1154.

Unfortunately it isn't possible to get this over the line just yet, because of this Vite issue:

image

(The /baz/qux stuff comes from here...

...and is getting hard-coded in the Vite build. Ideally it would resolve the CSS assets relative to import.meta.url.)

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts

@vercel
Copy link

vercel bot commented Apr 20, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sveltejs/kit-demo/4u6izKqM6dz1WYzohqD1H3m2hBf2
✅ Preview: https://kit-demo-git-gh-1154-sveltejs1.vercel.app

@Rich-Harris Rich-Harris mentioned this pull request Apr 25, 2021
@benmccann benmccann changed the title Clear paths config on svelte-kit start Clear paths config on svelte-kit preview Aug 5, 2021
@Rich-Harris
Copy link
Member Author

this is made obsolete by #2189 — closing

@dummdidumm dummdidumm deleted the gh-1154 branch August 17, 2021 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants