Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: decode asset URLs in dev when reading them #12341

Merged
merged 4 commits into from
Jun 14, 2024
Merged

Conversation

Rich-Harris
Copy link
Member

The read function from $app/server fails in development if the asset being read contains url-encoded characters in the filename. For example, if you have a file like content/[foo].txt, this will fail:

import { read } from '$app/server';

const files = import.meta.glob('./content/**', { eager: true, query: '?url' });
const data = await read(files['./content/[foo].txt'].default).text();

This PR fixes it by wrapping the asset URL in decodeURIComponent (but only in dev, as it's unnecessary in prod).


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Jun 14, 2024

🦋 Changeset detected

Latest commit: b768312

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris merged commit be72092 into main Jun 14, 2024
11 of 13 checks passed
@Rich-Harris Rich-Harris deleted the fix-read-file branch June 14, 2024 15:31
@github-actions github-actions bot mentioned this pull request Jun 14, 2024
@hyunbinseo
Copy link
Contributor

Does this fix the following issues?

I'm going to close this as a duplicate of #12265. They're both URL encoding issues.

@Rich-Harris
Copy link
Member Author

Ah nice! Yes, those should be fixed now - closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants