Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: catch stack trace fixing errors thrown in web containers #12775

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

eltigerchino
Copy link
Member

@eltigerchino eltigerchino commented Oct 9, 2024

@paoloricciuti 's solution in #10638 helps catch the anonymous Vite error (shown below) that appears in web containers such as stackblitz, sveltekit.new , etc. Instead, it returns the original unfixed stack trace in the event that it is unable to fix the stack trace.

Error: `line` must be greater than 0 (lines start at line 1)

Although, the returned stack trace line number reported is unfixed, it's better than not having any useful errors reported.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Oct 9, 2024

🦋 Changeset detected

Latest commit: bf63e39

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@eltigerchino eltigerchino changed the title fix: catch "fix stack trace" errors fix: catch "fix stack trace" error Oct 9, 2024
@eltigerchino eltigerchino changed the title fix: catch "fix stack trace" error fix: catch "fix stack trace" error thrown in web containers Oct 9, 2024
@eltigerchino eltigerchino changed the title fix: catch "fix stack trace" error thrown in web containers fix: catch stack trace fixing errors thrown in web containers Oct 9, 2024
@dummdidumm dummdidumm merged commit 5241d8a into main Oct 9, 2024
13 checks passed
@dummdidumm dummdidumm deleted the fix-web-container-stack-trace branch October 9, 2024 10:12
@github-actions github-actions bot mentioned this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-decision Not sure if we want to do this yet, also design work needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants