Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade adapters esbuild to latest #1627

Merged
merged 1 commit into from
Jun 2, 2021
Merged

Upgrade adapters esbuild to latest #1627

merged 1 commit into from
Jun 2, 2021

Conversation

haishanh
Copy link
Contributor

@haishanh haishanh commented Jun 2, 2021

The esbuild version of Vercel, Netlify, and Cloudflare Workers adapter has been ^0.11.18 for a while. It's been upgraded to ^0.12.5 in this PR.

Personally I'm using prisma 2 in my SvelteKit app on Vercel. Prisma client depends on the module undici which in turn depends on a Node internal module called _http_common. Since this node internal module was not in esbuild's Node internal module list, svelte-kit build failed due to esbuild not able to resolve _http_common. This is fixed in esbuild 0.12.1.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts

Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. esbuild for vite was upgraded to 0.12.5 here: #1625

@benmccann benmccann merged commit c51ab7d into sveltejs:master Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants