Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Todo delete button not disabling while waiting for API response #2172

Merged
merged 6 commits into from
Aug 12, 2021
Merged

Fix Todo delete button not disabling while waiting for API response #2172

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7a485e2
Fix delete button not being disabled while waiting for response
ric2b Aug 12, 2021
58f1697
Remove need for initializing `pending_delete` variable
ric2b Aug 12, 2021
67fd607
Create wicked-humans-taste.md
benmccann Aug 12, 2021
a52dded
remove ~TODO~ from patch change
ignatiusmb Aug 12, 2021
861e0f1
Update packages/create-svelte/templates/default/src/routes/todos/inde…
ric2b Aug 12, 2021
636eb96
update typescript definition
ric2b Aug 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/wicked-humans-taste.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"create-svelte": patch
"~TODO~": patch
ignatiusmb marked this conversation as resolved.
Show resolved Hide resolved
---

Disable delete button while waiting for API response
3 changes: 2 additions & 1 deletion packages/create-svelte/templates/default/src/routes/todos/index.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,12 +105,13 @@
action="/todos/{todo.uid}.json?_method=delete"
method="post"
use:enhance={{
pending: () => todo.pending_delete = true,
ric2b marked this conversation as resolved.
Show resolved Hide resolved
result: () => {
todos = todos.filter((t) => t.uid !== todo.uid);
}
}}
>
<button class="delete" aria-label="Delete todo" />
<button class="delete" aria-label="Delete todo" disabled={!!todo.pending_delete} />
ric2b marked this conversation as resolved.
Show resolved Hide resolved
</form>
</div>
{/each}
Expand Down