Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] exclude emitted declarations on packaging #2247

Merged
merged 28 commits into from
Aug 22, 2021
Merged

[fix] exclude emitted declarations on packaging #2247

merged 28 commits into from
Aug 22, 2021

Conversation

ignatiusmb
Copy link
Member

This PR contains fixes for a couple of things, including but not limited to

  • properly excluding files as well as its generated declarations
  • improvements for the globbing pattern users can provide
  • nested files not included/excluded on windows machines

Changing our globbing package allows end-users to provide more complex but easier (more familiar, bash-like) to write patterns. It's not as tiny in size as the previous one, but we're only using it for the packaging cli, and the patterns it allows our users to write also relieves a lot of normalizing and handling on our side as well.

Fixes #1923, waiting #2236 for this to be reviewed

@changeset-bot
Copy link

changeset-bot bot commented Aug 19, 2021

🦋 Changeset detected

Latest commit: c724841

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ignatiusmb ignatiusmb marked this pull request as ready for review August 21, 2021 09:00
@ignatiusmb
Copy link
Member Author

This may also remove handwritten .d.ts that are not part of the exclude pattern, but then again, it doesn't really make sense to publish the typings without the logic. Except for a different case when it only contains export type, in which case users should make sure it is isolated properly and won't be caught by their glob pattern, or rely on .npmignore.

I wanted to add some disclaimer in the docs that users are fully responsible for their glob patterns when they're using the include/exclude options. But, those who are using these options should have known better themselves. I guess we'll have to see if there's any complaint later on.

@ignatiusmb ignatiusmb merged commit aaea5cf into sveltejs:master Aug 22, 2021
@ignatiusmb ignatiusmb deleted the i1923/filter-emitted-excluded branch August 22, 2021 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

emit_dts in svelte-kit package should respect the file excludes config
2 participants