-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vercel externals #3614
Vercel externals #3614
Conversation
🦋 Changeset detectedLatest commit: 86a7ea2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✔️ Deploy Preview for kit-demo canceled. 🔨 Explore the source changes: 86a7ea2 🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/61f5b36c4e3de5000750b2fd |
packages/adapter-vercel/index.d.ts
Outdated
@@ -1,4 +1,4 @@ | |||
import { Adapter } from '@sveltejs/kit'; | |||
|
|||
declare function plugin(): Adapter; | |||
declare function plugin({ external }?: { external?: string[] }): Adapter; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if it's worth having the param as plugin(options?: Options)
instead to simplify the type signature for intellisense, and conforms with the docs wording of "You can pass an options
argument". But this PR is fine with the current type too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sense, i made that change
fixes #3588, by adding an
external
option that gets passed to esbuildPlease don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpx changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0