Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vercel externals #3614

Merged
merged 3 commits into from
Jan 29, 2022
Merged

Vercel externals #3614

merged 3 commits into from
Jan 29, 2022

Conversation

Rich-Harris
Copy link
Member

fixes #3588, by adding an external option that gets passed to esbuild

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Jan 29, 2022

🦋 Changeset detected

Latest commit: 86a7ea2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Jan 29, 2022

✔️ Deploy Preview for kit-demo canceled.

🔨 Explore the source changes: 86a7ea2

🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/61f5b36c4e3de5000750b2fd

@@ -1,4 +1,4 @@
import { Adapter } from '@sveltejs/kit';

declare function plugin(): Adapter;
declare function plugin({ external }?: { external?: string[] }): Adapter;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it's worth having the param as plugin(options?: Options) instead to simplify the type signature for intellisense, and conforms with the docs wording of "You can pass an options argument". But this PR is fine with the current type too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense, i made that change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vercel Build Fails as Can't Set EsBuild Externals
2 participants