Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3505 - json response condition update #3624

Merged
merged 5 commits into from
Jan 29, 2022

Conversation

vicky1999
Copy link
Contributor

Solves #3505

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Jan 29, 2022

⚠️ No Changeset found

Latest commit: 533f4a8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Jan 29, 2022

✔️ Deploy Preview for kit-demo canceled.

🔨 Explore the source changes: 79c939c

🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/61f5b3b50b32b00008ff49db

@bluwy bluwy linked an issue Jan 29, 2022 that may be closed by this pull request
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
@bluwy
Copy link
Member

bluwy commented Jan 29, 2022

LGTM. Please add a changeset too.

@vicky1999
Copy link
Contributor Author

@bluwy changeset added

@Rich-Harris
Copy link
Member

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Endpoint Response breaks with "content-type: application/json"
3 participants