Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes client-side not navigating if same shadow route module used #3814

Closed

Conversation

PH4NTOMiki
Copy link
Contributor

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Fixes #3727
Needs tests

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Feb 10, 2022

🦋 Changeset detected

Latest commit: 049a627

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Feb 10, 2022

✔️ Deploy Preview for kit-demo canceled.

🔨 Explore the source changes: 049a627

🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/62052584d59d250007d4c8ce

@PH4NTOMiki
Copy link
Contributor Author

@bluwy @benmccann can we merge this?
It's quite a bug.

@Rich-Harris
Copy link
Member

Thank you. I went with a slightly different solution in #3925 — eventually we'll probably want a more granular solution when we have shadowed layouts, which means applying the same kind of dependency detection on the server side (and probably communicating it to the client via custom headers), which means that populating node.uses is arguably preferable to adding special casing in the change detection block

@PH4NTOMiki PH4NTOMiki deleted the fix-check-if-shadow-route-changed branch March 4, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shadow endpoints navigation within same route
2 participants