Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent double-fixing of stack traces #4041

Merged
merged 6 commits into from
Feb 23, 2022
Merged

prevent double-fixing of stack traces #4041

merged 6 commits into from
Feb 23, 2022

Conversation

Rich-Harris
Copy link
Member

fixes #3638. The problem here was that errors were having their stack traces 'fixed' (which is not an idempotent operation) twice in some cases, resulting in invalid source mappings.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Feb 22, 2022

🦋 Changeset detected

Latest commit: aa9e51b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member Author

Couple of related issues: #3243 and #3371. #3243 isn't yet fixed by this PR, I haven't checked #3371 yet.

@Rich-Harris
Copy link
Member Author

The test that's failing is because errors that occur during ssrLoadModule are already 'fixed', and we try to fix them again. Not sure what the most elegant way to prevent that is, will pick up tomorrow

@Rich-Harris
Copy link
Member Author

Working around the fact that ssrLoadModule fixes stack traces is proving to be very difficult. Decided to skip that test and open vitejs/vite#7046 instead.

@Rich-Harris Rich-Harris marked this pull request as ready for review February 23, 2022 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"TypeError: Line must be greater than or equal to 1, got 0" when cross-fetching endpoints
2 participants