Param validators #4334
Merged
Param validators #4334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3555883 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
benmccann
reviewed
Mar 16, 2022
| @@ -41,10 +42,13 @@ export function generate_manifest({ build_data, relative_path, routes, format = | |||
| }); | |||
|
|
|||
| /** @type {(path: string) => string} */ | |||
| const importer = | |||
| const load = | |||
There was a problem hiding this comment.
I personally liked importer a bit more to avoid conflating with the page load
There was a problem hiding this comment.
this is quite far away from anything touching page, but the endpoints constructed here do have a load method, so it arguably makes more sense this way. though the reason i changed it was because we need both import(...) and () => import(...), and while import/importer would have been a good combo, import isn't a valid variable name whereas load is.
| @@ -114,6 +115,8 @@ export async function respond(request, options, state) { | |||
| transformPage: default_transform | |||
| }; | |||
|
|
|||
| // TODO match route before calling handle? | |||
benmccann
reviewed
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP. Adds parameter validators (#4291). Part 2 of 2, follows #4330.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpx changesetand following the prompts. All changesets should bepatchuntil SvelteKit 1.0