Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Merge ErrorLoad and Load, make Input and Output typings public #4515

Conversation

elliott-with-the-longest-name-on-github
Copy link
Contributor

Merged the declarations of ErrorLoad and Load and their corresponding input types ErrorLoadInput and LoadInput. Moved the LoadInput and LoadOutput interfaces to index.d.ts from private.d.ts.

No behaviors have actually been changed, but the status and error properties are now part of the official public API.

See issue #4461 for discussion.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it. no changed behavior

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check One test is failing for me locally, but it is also failing on master

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

- Moved LoadInput and LoadOutput from private.d.ts to public.d.ts
- Combined definitions of ErrorLoad and Load
- Combined definitions of ErrorLoadInput and LoadInput
- Updated references to old ErrorXxx types
- Added boilerplate to make status and error props null in the default case
@changeset-bot
Copy link

changeset-bot bot commented Apr 4, 2022

🦋 Changeset detected

Latest commit: b34fa52

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

Thank you!

Rich-Harris pushed a commit that referenced this pull request Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants