-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle non-200 status codes from root __layout.svelte
#4665
Conversation
🦋 Changeset detectedLatest commit: 6b6c485 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
I haven't fully been following what's happening in that issue - but from your description in this PR, it sounds at least somewhat adjacent to #3068 - although the symptoms are different |
#4659. Just a failing test for now. Looks like the 'bail out and render a generic 500 if an error occurs while rendering an error page' thing only applies to errors that are thrown;
return { status: 404 }
doesn't do the trick.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpx changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0