-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
default to target: node14.8 #4742
Conversation
🦋 Changeset detectedLatest commit: dcc7a12 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
It's using
esbuild keeps a compat table for top level await. It only exists in 14.8, so specifying |
nice, it does |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the package.json
have "node": ">=14.13"
so we should be safe with the change too.
Co-authored-by: Conduitry <git@chor.date>
Hi is it possible to add this to the vercel adapter as well? Building to vercel still fails with top-level await errors and looks like that adapter is set to node14 |
Fixes #1538, where I recommended that people do async setup work in
src/hooks.js
(or any other module, really) using top-level await. This works wonderfully in development, but it turns outsvelte-kit build
fails because Vite runs everything throughesbuild
(not sure why, if I'm perfectly honest, but that's a separate conversation) and we currently usetarget: 'es2020'
which doesn't allow top-level await:This changes it to
node16
. I triednode14
at first, but that still didn't work even though top-level await definitely is supported there. I think this is probably fine, and at any rate, you can override it inconfig.kit.vite.build.target
.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpx changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0