Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Project Structure #4829

Closed
wants to merge 82 commits into from
Closed

[Docs] Project Structure #4829

wants to merge 82 commits into from

Conversation

Mlocik97
Copy link
Contributor

@Mlocik97 Mlocik97 commented May 5, 2022

fixes #4748

rendered

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented May 5, 2022

⚠️ No Changeset found

Latest commit: a6ddad9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR


Typicall structure of SvelteKit project is something like:

```sh
Copy link
Contributor Author

@Mlocik97 Mlocik97 May 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what to use so comments are shown as comments but everything else as standard text.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about using the skeleton app structure, and speaking about option folders like params or generated folders like .svelte-kit/ and build/ when speaking about them in their parents' descriptions?

This is the output I've got using tree (tree -aC --dirsfirst --gitignore added / manually):

├── src/
│   ├── routes/
│   │   └── index.svelte
│   ├── app.d.ts
│   └── app.html
├── static/
│   └── favicon.png
├── tests/
│   └── test.js
├── .eslintrc.cjs
├── .gitignore
├── .npmrc
├── .prettierrc
├── README.md
├── jsconfig.json
├── package.json
├── playwright.config.js
└── svelte.config.js

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better if all of important files are included, so it's really fast visible to where put for example params/ folder, that doesn't exist yet without need to search it deeper in docs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, that's a very important folder of which, BTW, I didn't know about. ☺️
But I would keep it super simple to avoid to overwhelm the reader with "advanced" information, still mentioning them in their related section in the documentation page.
In this case, the section where we explain what the src/ folder is about.
Makes sense?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to have it all at one place together visible,... it doesn't really add that much mess and it's quite visible which files are where.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking about it, that's true. For sure, I've already learned something new looking at it. ☺️ 👍

documentation/docs/01-project-structure.md Outdated Show resolved Hide resolved
documentation/docs/01-project-structure.md Outdated Show resolved Hide resolved
documentation/docs/01-project-structure.md Outdated Show resolved Hide resolved
documentation/docs/01-project-structure.md Outdated Show resolved Hide resolved
documentation/docs/01-project-structure.md Outdated Show resolved Hide resolved
documentation/docs/01-project-structure.md Outdated Show resolved Hide resolved
documentation/docs/01-project-structure.md Outdated Show resolved Hide resolved
documentation/docs/01-project-structure.md Outdated Show resolved Hide resolved
documentation/docs/01-project-structure.md Outdated Show resolved Hide resolved
documentation/docs/01-project-structure.md Outdated Show resolved Hide resolved
Mlocik97 and others added 3 commits May 5, 2022 17:32
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
@Rich-Harris
Copy link
Member

closed in favour of #5430 — thanks for getting the ball rolling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Orientation
6 participants