-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node polyfills #4934
Node polyfills #4934
Conversation
🦋 Changeset detectedLatest commit: 453bc68 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Will this mean that libraries that rely on node dependencies in a non-node environment such as CloudFlare Pages have a chance of working? i.e. stripe |
No, it's the opposite — it's bringing the Node environment up to date with other more web-like ones, where Ideally, those libraries should be updated to use web APIs, instead of assuming they're running in Node. |
Just FYI, Vite is likely switching to |
We really need to use |
Added |
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
This replaces
@sveltejs/kit/install-fetch
with@sveltejs/kit/node/polyfills
, and addscrypto
to the list of web APIs that are guaranteed to be present.addAbortController
(prevent scroll when resetting page focus (#4065) #4846)node-fetch
forundici
, which is more standards compliant (though I think we're blocked on Undici strips out set-cookie headers, even when "credentials: 'include'" is set nodejs/undici#1262)@sveltejs/kit/node/polyfills/16
and@sveltejs/kit/node/polyfills/18
)Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0