-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] Use vite preview port in templates for playwright config #5433
[fix] Use vite preview port in templates for playwright config #5433
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! A few suggestions
Co-authored-by: Rich Harris <hello@rich-harris.dev>
Co-authored-by: Rich Harris <hello@rich-harris.dev>
Co-authored-by: Rich Harris <hello@rich-harris.dev>
Co-authored-by: Rich Harris <hello@rich-harris.dev>
Thank you for your suggestions. |
thanks! |
Closes #5429 which was introduced with #5392.
I have changed the web server port from 3000 to 4173 in the
playwright.config.js
templates to be in line with the preview server ports fromvite
.I am not totally sure if the changes to the tests are good enough. But if the
vite
ports will change in the future the tests should be failing.I am also not quite sure if my selections for the changeset are correct.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0