Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use pull method #5442

Merged
merged 5 commits into from
Jul 12, 2022
Merged

use pull method #5442

merged 5 commits into from
Jul 12, 2022

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Jul 9, 2022

Closes #5412.

I'm not 100% sure this is correct — in particular, I'm not sure what's supposed to happen if someone tries to upload a huge file and you early-exit with a 413; the response doesn't seem to get acknowledged while the request is still pending (which never stops being true, if you don't buffer it or create a reader).

But it does fix the vulnerability — data is only buffered if you ask for it to be buffered.

No test because I'm not really sure how you'd go about testing such a thing.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Jul 9, 2022

🦋 Changeset detected

Latest commit: 37f99ea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@AlessioGr
Copy link

AlessioGr commented Jul 16, 2022

data is only buffered if you ask for it to be buffered.

How can I do that? How do I ask for it to be buffered?

How can I customize or disable this size limit for some POST listeners?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vulnerability: Memory Overflow when sending big files
3 participants