Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Initialize $env/dynamic/* in the module declaration itself for development modes #6454

Merged
merged 8 commits into from
Sep 5, 2022

Conversation

elliott-with-the-longest-name-on-github
Copy link
Contributor

This allows us to support Vite ecosystem tools such as Vitest and vite-node. No additional tests because behavior should not change at all.

Closes #6225.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Aug 31, 2022

🦋 Changeset detected

Latest commit: 79efb44

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

documentation/docs/15-configuration.md Outdated Show resolved Hide resolved
documentation/docs/15-configuration.md Outdated Show resolved Hide resolved
@Rich-Harris
Copy link
Member

I'm not sure I understand the devModes stuff. Surely the only thing that matters is whether the command is build or serve? I can't see where it's being referenced in the code

@netlify
Copy link

netlify bot commented Sep 5, 2022

Deploy Preview for kit-demo ready!

Name Link
🔨 Latest commit 79efb44
🔍 Latest deploy log https://app.netlify.com/sites/kit-demo/deploys/63156848ae7977000983518b
😎 Deploy Preview https://deploy-preview-6454--kit-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@elliott-with-the-longest-name-on-github
Copy link
Contributor Author

I can't see why Cloudflare failed. Is it a flake on their part or something actually broken?

@elliott-with-the-longest-name-on-github
Copy link
Contributor Author

@acarl005 I'm curious if this branch fixes your vite-node problem. I'm getting a werid, cryptic error when trying to run scripts with vite-node on this branch, but it occurs after the script has executed (with the expected environment variables populated)!

@Rich-Harris
Copy link
Member

I can't see why Cloudflare failed. Is it a flake on their part or something actually broken?

It failed on installing playwright of all things. Kicked off a new build

@Rich-Harris Rich-Harris merged commit dbb8e7d into master Sep 5, 2022
@Rich-Harris Rich-Harris deleted the 6225/sejohnson-vite-ecosystem-env-compatibility branch September 5, 2022 13:33
@github-actions github-actions bot mentioned this pull request Sep 5, 2022
@acarl005
Copy link

acarl005 commented Sep 5, 2022

@tcc-sejohnson Yes! Thanks y'all!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

$env/dynamic/private not getting loaded by vitest and vite-node
4 participants