Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Form actions #6469

Merged
merged 93 commits into from
Sep 6, 2022
Merged

Form actions #6469

merged 93 commits into from
Sep 6, 2022

Commits on Aug 31, 2022

  1. basic actions method

    @dummdidumm
    dummdidumm committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    1c3ba7a View commit details
    Browse the repository at this point in the history

  2. add form store

    @dummdidumm
    dummdidumm committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    9ac19bc View commit details
    Browse the repository at this point in the history

  3. remove export let errors in favor of form store

    @dummdidumm
    dummdidumm committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    7b71fa3 View commit details
    Browse the repository at this point in the history

  4. make actions an object

    @dummdidumm
    dummdidumm committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    d880096 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2022

  1. implement FilesFormData

    @dummdidumm
    dummdidumm committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    102851b View commit details
    Browse the repository at this point in the history

  2. restrict values type, fix conversion, switch argument order

    @dummdidumm
    dummdidumm committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    e650cb3 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into form-actions

    @dummdidumm
    dummdidumm committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    678361d View commit details
    Browse the repository at this point in the history

  4. validation->invalid

    @dummdidumm
    dummdidumm committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    5ece9c0 View commit details
    Browse the repository at this point in the history

  5. start writing docs

    @dummdidumm
    dummdidumm committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    9c9dfbe View commit details
    Browse the repository at this point in the history

  6. implement handleFile

    @dummdidumm
    dummdidumm committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    b11c578 View commit details
    Browse the repository at this point in the history

  7. fix tests

    @dummdidumm
    dummdidumm committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    3450eb4 View commit details
    Browse the repository at this point in the history

  8. test for files

    @dummdidumm
    dummdidumm committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    38a253c View commit details
    Browse the repository at this point in the history

  9. complete migration message

    @dummdidumm
    dummdidumm committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    2da72d9 View commit details
    Browse the repository at this point in the history

  10. support validation error thrown in endpoints

    @dummdidumm
    dummdidumm committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    62fa93c View commit details
    Browse the repository at this point in the history

  11. infer file type from handleFile hook

    @dummdidumm
    dummdidumm committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    225be5c View commit details
    Browse the repository at this point in the history

  12. add handleFile to build

    @dummdidumm
    dummdidumm committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    7ce58ea View commit details
    Browse the repository at this point in the history

  13. types, cleanup

    @dummdidumm
    dummdidumm committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    9dcb6be View commit details
    Browse the repository at this point in the history

  14. $form -> $submitted

    @dummdidumm
    dummdidumm committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    f1941a5 View commit details
    Browse the repository at this point in the history

  15. woops

    @dummdidumm
    dummdidumm committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    71ed352 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2022

  1. allow arbitrary data on invalid, persist data in success case

    @dummdidumm
    dummdidumm committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    ba0f204 View commit details
    Browse the repository at this point in the history

  2. fix infered FileType

    @dummdidumm
    dummdidumm committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    f6be2c5 View commit details
    Browse the repository at this point in the history

  3. give JSON response a well-defined shape

    @dummdidumm
    dummdidumm committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    d8e7137 View commit details
    Browse the repository at this point in the history

  4. provide form state through form prop and $page.form

    @dummdidumm
    dummdidumm committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    b2e30b9 View commit details
    Browse the repository at this point in the history

  5. return invalid instead of throwing it

    @dummdidumm
    dummdidumm committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    29294d0 View commit details
    Browse the repository at this point in the history

  6. types for actions

    @dummdidumm
    dummdidumm committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    ba4aa8f View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'origin/master' into form-actions

    @dummdidumm
    dummdidumm committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    be35a3a View commit details
    Browse the repository at this point in the history

  8. fix, skip test

    @dummdidumm
    dummdidumm committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    855c1b8 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2022

  1. Merge remote-tracking branch 'origin/master' into form-actions

    @dummdidumm
    dummdidumm committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    09c10af View commit details
    Browse the repository at this point in the history

  2. updateForm (simple version)

    @dummdidumm
    dummdidumm committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    2a14eaf View commit details
    Browse the repository at this point in the history

  3. making a start at enhance

    @dummdidumm
    dummdidumm committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    792b659 View commit details
    Browse the repository at this point in the history

  4. bye bye method overrides

    @dummdidumm
    dummdidumm committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    ca3cae9 View commit details
    Browse the repository at this point in the history

  5. update create-svelte default template

    @dummdidumm
    dummdidumm committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    8d9fe0b View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'origin/master' into form-actions

    @dummdidumm
    dummdidumm committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    823153f View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2022

  1. remove handleFile

    @dummdidumm
    dummdidumm committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    6213bf0 View commit details
    Browse the repository at this point in the history

  2. full blown enhance and updateForm through $app/forms

    @dummdidumm
    dummdidumm committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    646013b View commit details
    Browse the repository at this point in the history

  3. fix type reference

    @dummdidumm
    dummdidumm committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    d82933f View commit details
    Browse the repository at this point in the history

  4. adjust default template

    @dummdidumm
    dummdidumm committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    16f1ad4 View commit details
    Browse the repository at this point in the history

  5. remove $page.form for now (too much of a footgun due to resets)

    @dummdidumm
    dummdidumm committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    9eef9a7 View commit details
    Browse the repository at this point in the history

  6. tests, ensure form is only reset on page changes

    @dummdidumm
    dummdidumm committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    f17ef01 View commit details
    Browse the repository at this point in the history

  7. ?????

    @dummdidumm
    dummdidumm committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    c208888 View commit details
    Browse the repository at this point in the history

  8. cleanup

    @dummdidumm
    dummdidumm committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    f0d0222 View commit details
    Browse the repository at this point in the history

  9. docs about multiple forms

    @dummdidumm
    dummdidumm committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    d43a085 View commit details
    Browse the repository at this point in the history

  10. make docs build

    @dummdidumm
    dummdidumm committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    f3926c4 View commit details
    Browse the repository at this point in the history

  11. lint

    @Rich-Harris
    Rich-Harris committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    1045828 View commit details
    Browse the repository at this point in the history

  12. fix

    @Rich-Harris
    Rich-Harris committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    2123945 View commit details
    Browse the repository at this point in the history

  13. add toggle action

    @Rich-Harris
    Rich-Harris committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    e1aadca View commit details
    Browse the repository at this point in the history

  14. rename generated FormData type to ActionData

    @Rich-Harris
    Rich-Harris committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    b19bb4b View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2022

  1. reset form on navigation, not invalidation

    @Rich-Harris
    Rich-Harris committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    2647a10 View commit details
    Browse the repository at this point in the history

  2. silence missing/unused form prop warnings, DRY out code a bit

    @Rich-Harris
    Rich-Harris committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    0eb68e2 View commit details
    Browse the repository at this point in the history

  3. Update packages/kit/src/runtime/server/page/actions.js

    @Rich-Harris
    Rich-Harris authored Sep 5, 2022
    Configuration menu
    Copy the full SHA
    6fe185a View commit details
    Browse the repository at this point in the history

  4. Update packages/kit/src/runtime/server/page/actions.js

    @Rich-Harris
    Rich-Harris authored Sep 5, 2022
    Configuration menu
    Copy the full SHA
    21b9f46 View commit details
    Browse the repository at this point in the history

  5. Update packages/kit/src/runtime/server/page/actions.js

    @Rich-Harris
    Rich-Harris authored Sep 5, 2022
    Configuration menu
    Copy the full SHA
    7bc739e View commit details
    Browse the repository at this point in the history

  6. change message to reference actions

    @Rich-Harris
    Rich-Harris committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    c3c8369 View commit details
    Browse the repository at this point in the history

  7. Update packages/kit/src/runtime/server/page/actions.js

    @Rich-Harris
    Rich-Harris authored Sep 5, 2022
    Configuration menu
    Copy the full SHA
    732093c View commit details
    Browse the repository at this point in the history

  8. Update packages/kit/src/runtime/server/page/actions.js

    @Rich-Harris
    Rich-Harris authored Sep 5, 2022
    Configuration menu
    Copy the full SHA
    333b87a View commit details
    Browse the repository at this point in the history

  9. be more specific about what content-type is accepted

    @Rich-Harris
    Rich-Harris committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    b561522 View commit details
    Browse the repository at this point in the history

  10. Update packages/kit/src/runtime/server/page/render.js

    @Rich-Harris
    Rich-Harris authored Sep 5, 2022
    Configuration menu
    Copy the full SHA
    e17acfd View commit details
    Browse the repository at this point in the history

  11. Update packages/kit/src/runtime/server/page/render.js

    @Rich-Harris
    Rich-Harris authored Sep 5, 2022
    Configuration menu
    Copy the full SHA
    a3a21ca View commit details
    Browse the repository at this point in the history

  12. unskip test

    @Rich-Harris
    Rich-Harris committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    260e0d4 View commit details
    Browse the repository at this point in the history

  13. Merge branch 'form-actions' of github.com:sveltejs/kit into form-actions

    @Rich-Harris
    Rich-Harris committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    fa78907 View commit details
    Browse the repository at this point in the history

  14. fix types

    @dummdidumm
    dummdidumm committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    7c8c360 View commit details
    Browse the repository at this point in the history

  15. tweak enhance function and make todos example work again

    @dummdidumm
    dummdidumm committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    b081e8c View commit details
    Browse the repository at this point in the history

  16. changeset

    @dummdidumm
    dummdidumm committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    60b8341 View commit details
    Browse the repository at this point in the history

  17. deduplicate type usage

    @dummdidumm
    dummdidumm committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    3be2e9e View commit details
    Browse the repository at this point in the history

  18. merge

    @Rich-Harris
    Rich-Harris committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    4119273 View commit details
    Browse the repository at this point in the history

  19. lint

    @dummdidumm
    dummdidumm committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    26908ba View commit details
    Browse the repository at this point in the history

  20. wording, make updateForm (now applySubmissionResult) more powerful

    @dummdidumm
    dummdidumm committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    34e515b View commit details
    Browse the repository at this point in the history

  21. fix, docs

    @dummdidumm
    dummdidumm committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    e62a6ea View commit details
    Browse the repository at this point in the history

  22. applySubmissionResult -> applyAction

    @dummdidumm
    dummdidumm committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    91b143c View commit details
    Browse the repository at this point in the history

  23. change enhance function signature

    @dummdidumm
    dummdidumm committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    b94a89a View commit details
    Browse the repository at this point in the history

  24. fix template

    @dummdidumm
    dummdidumm committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    5c15c23 View commit details
    Browse the repository at this point in the history

  25. fix template

    @dummdidumm
    dummdidumm committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    3275ebb View commit details
    Browse the repository at this point in the history

  26. merge

    @Rich-Harris
    Rich-Harris committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    45580ac View commit details
    Browse the repository at this point in the history

  27. Update .changeset/spicy-pugs-applaud.md

    @Rich-Harris
    Rich-Harris authored Sep 5, 2022
    Configuration menu
    Copy the full SHA
    d11c059 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2022

  1. Update packages/kit/src/runtime/app/forms.js

    @Rich-Harris
    Rich-Harris authored Sep 6, 2022
    Configuration menu
    Copy the full SHA
    4198872 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review

    @Rich-Harris
    Rich-Harris authored Sep 6, 2022
    Configuration menu
    Copy the full SHA
    a09aad3 View commit details
    Browse the repository at this point in the history

  3. prettier

    @Rich-Harris
    Rich-Harris committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    840f714 View commit details
    Browse the repository at this point in the history

  4. rename SubmissionResult to ActionResult

    @Rich-Harris
    Rich-Harris committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    7eb124b View commit details
    Browse the repository at this point in the history

  5. Update packages/kit/types/ambient.d.ts

    @Rich-Harris
    Rich-Harris authored Sep 6, 2022
    Configuration menu
    Copy the full SHA
    7ff7e7f View commit details
    Browse the repository at this point in the history

  6. Update packages/kit/types/ambient.d.ts

    @Rich-Harris
    Rich-Harris authored Sep 6, 2022
    Configuration menu
    Copy the full SHA
    ff023d4 View commit details
    Browse the repository at this point in the history

  7. updateForm -> applyAction

    @Rich-Harris
    Rich-Harris committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    1b194bb View commit details
    Browse the repository at this point in the history

  8. use RequestEvent instead of ActionEvent

    @Rich-Harris
    Rich-Harris committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    7b6e988 View commit details
    Browse the repository at this point in the history

  9. fix

    @Rich-Harris
    Rich-Harris committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    9385bd0 View commit details
    Browse the repository at this point in the history

  10. invalidate first, delegate redirect/error handling to applyAction

    @Rich-Harris
    Rich-Harris committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    c393862 View commit details
    Browse the repository at this point in the history

  11. remove token stuff, simplify a bit

    @Rich-Harris
    Rich-Harris committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    bb910be View commit details
    Browse the repository at this point in the history

  12. show +error page without reloading route

    @Rich-Harris
    Rich-Harris committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    e28d384 View commit details
    Browse the repository at this point in the history

  13. check action return data can be serialized as JSON

    @Rich-Harris
    Rich-Harris committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    7ee1425 View commit details
    Browse the repository at this point in the history

  14. add note to render.js

    @Rich-Harris
    Rich-Harris committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    3906922 View commit details
    Browse the repository at this point in the history

  15. merge FetchFormResponse and ActionResult

    @Rich-Harris
    Rich-Harris committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    0f1f5c3 View commit details
    Browse the repository at this point in the history

  16. update docs

    @Rich-Harris
    Rich-Harris committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    d899b30 View commit details
    Browse the repository at this point in the history

  17. remove logging

    @Rich-Harris
    Rich-Harris committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    5ee4fcd View commit details
    Browse the repository at this point in the history

  18. tiny docs tweak

    @dummdidumm
    dummdidumm committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    a0d7580 View commit details
    Browse the repository at this point in the history

  19. merge

    @Rich-Harris
    Rich-Harris committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    f2cdab2 View commit details
    Browse the repository at this point in the history