-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[breaking] only allow enhance on form; pass abort controller #6662
Conversation
🦋 Changeset detectedLatest commit: 08ee633 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Questioned my sanity until I discovered that |
Ok so fixed the issue by applying the logic I described above. The abort controller behavior now is that it not invokes the callback return function, which seems like the best thing to do. I didn't want to introduce another |
This is a breaking change because the
element
property was removed fromenhance
and the action only is possible to apply to forms again; also the interface generic has been removed accordingly.Fixes #6660
Superseedes/closes #6658
Reverts #6633, because we can achieve the same with
event.submitter
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0