Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[breaking] only allow enhance on form; pass abort controller #6662

Merged
merged 6 commits into from
Sep 8, 2022

Conversation

dummdidumm
Copy link
Member

@dummdidumm dummdidumm commented Sep 8, 2022

This is a breaking change because the element property was removed from enhance and the action only is possible to apply to forms again; also the interface generic has been removed accordingly.

Fixes #6660
Superseedes/closes #6658
Reverts #6633, because we can achieve the same with event.submitter

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Sep 8, 2022

🦋 Changeset detected

Latest commit: 08ee633

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm
Copy link
Member Author

Questioned my sanity until I discovered that event.submitter always seems to have formAction set - and to the default action if you don't have set it which causes subtle bugs. My idea is to check the formAction and infer if it is the default value and if the form has a non-default value then take the form's one, because we can't have both a default and a named action. The check also needs to take into account that actions could point to different URLs

@dummdidumm
Copy link
Member Author

Ok so fixed the issue by applying the logic I described above. The abort controller behavior now is that it not invokes the callback return function, which seems like the best thing to do. I didn't want to introduce another { type: 'aborted' }, which you could also make an argument for.

@Rich-Harris Rich-Harris merged commit 842f69b into master Sep 8, 2022
@Rich-Harris Rich-Harris deleted the enhance-again branch September 8, 2022 19:56
@github-actions github-actions bot mentioned this pull request Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use:enhance does not properly handle <button formaction="...">
3 participants