Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add missing routeId slashes #7469

Merged
merged 3 commits into from
Nov 2, 2022

Conversation

brunnerh
Copy link
Member

@brunnerh brunnerh commented Nov 2, 2022

Implementation was changed in #7338
Documentation was not updated everywhere.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Nov 2, 2022

⚠️ No Changeset found

Latest commit: a8a4272

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gtm-nayan gtm-nayan changed the title Add missing routeId slashes [docs] Add missing routeId slashes Nov 2, 2022
@gtm-nayan
Copy link
Contributor

gtm-nayan commented Nov 2, 2022

Thanks, the JSDoc comments for routeId in Page and RequestEvent also need to be updated in types/index.d.ts. @brunnerh could you get those as well in this PR?

@brunnerh
Copy link
Member Author

brunnerh commented Nov 2, 2022

Should be fixed.

@Rich-Harris Rich-Harris merged commit 39b7ef5 into sveltejs:master Nov 2, 2022
@Rich-Harris
Copy link
Member

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants